zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #274: Zookeeper 1748: Add option for tcp keepalive
Date Tue, 06 Jun 2017 00:07:33 GMT
Github user hanm commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -270,6 +271,8 @@ public void parseProperties(Properties zkProp)
                     quorumServicePrincipal = value;
                 } else if (key.equals("quorum.cnxn.threads.size")) {
                     quorumCnxnThreadsSize = Integer.parseInt(value);
    +            } else if (key.equals("tcpKeepAlive")) {
    +                tcpKeepAlive = Boolean.parseBoolean(value);
    --- End diff --
    As previously mentioned you can just let it fall through and query the system property
when we need set the sock option. 
    If we do need parse it, then we need handle potential exceptions on illegal values here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message