zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #274: Zookeeper 1748: Add option for tcp keepalive
Date Tue, 06 Jun 2017 00:02:14 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/274#discussion_r120238723
  
    --- Diff: docs/zookeeperAdmin.html ---
    @@ -1446,7 +1446,17 @@ <h3 class="h4">Configuration Parameters</h3>
                   </pre>
     </dd>
     
    -        
    +<dt>
    +<term>tcpKeepAlive</term>
    +</dt>
    +<dd>
    +<p>(No Java system property)</p>
    --- End diff --
    
    A config option by default will automatically be added as a system property with its name
as the suffix. In this case, the property will be "zookeeper.tcpKeepAlive", when the zoo.cfg
file is parsed. See QuorumPeerConfig.java for more details. So this doc should be updated.
    
    Having it as a system property is actually better as we can query the property when we
need it, instead of change the signatures of various classes and pass it around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message