Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Fri, 19 May 2017 17:37:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13072306.1494907465000.251970.1495215424284@Atlassian.JIRA>
In-Reply-To: <JIRA.13072306.1494907465000@Atlassian.JIRA>
References: <JIRA.13072306.1494907465000@Atlassian.JIRA> <JIRA.13072306.1494907465533@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code
 level for `SID` to avoid configuration problem
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 19 May 2017 17:37:10 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017725#comment-16017725 ] 

ASF GitHub Bot commented on ZOOKEEPER-2784:
-------------------------------------------

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/257#discussion_r117529199
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {
                     connectOne(sid);
                 }
     
    +        }else if (sid == self.getId()) {
    --- End diff --
    
    nit: space between `{` and `else`


> Add some limitations on code level for `SID` to avoid configuration problem
> ---------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2784
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>    Affects Versions: 3.5.2
>            Reporter: Benedict Jin
>             Fix For: 3.6.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> As so far, `QuorumCnxManager#receiveConnection` cannot find out the same `SID` problem, then the Zookeeper cluster will start successfully. But the cluster is not health, and it will throw some problem like `not synchronized`. So, i thought we should add some limitations on code level for `SID` to find those configuration problem more early.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)