Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Wed, 17 May 2017 12:29:04 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13069006.1493864913000.229882.1495024144271@Atlassian.JIRA>
In-Reply-To: <JIRA.13069006.1493864913000@Atlassian.JIRA>
References: <JIRA.13069006.1493864913000@Atlassian.JIRA> <JIRA.13069006.1493864913720@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2774) Ephemeral znode will not be
 removed when sesstion timeout, if the system time of ZooKeeper node changes
 unexpectedly.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 17 May 2017 12:29:08 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2774?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
16013936#comment-16013936 ]=20

Hadoop QA commented on ZOOKEEPER-2774:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
     =20

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 34 new or modified tes=
ts.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messa=
ges.

    +1 javac.  The applied patch does not increase the total number of java=
c compiler warnings.

    -1 findbugs.  The patch appears to introduce 90 new Findbugs (version 3=
.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number=
 of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-b=
uild/697//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github=
-pr-build/697//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.=
html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr=
-build/697//console

This message is automatically generated.

> Ephemeral znode will not be removed when sesstion timeout, if the system =
time of ZooKeeper node changes unexpectedly.
> -------------------------------------------------------------------------=
--------------------------------------------
>
>                 Key: ZOOKEEPER-2774
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2774
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.8, 3.4.9, 3.4.10
>         Environment: Centos6.5
>            Reporter: JiangJiafu
>
> 1. Deploy a ZooKeeper cluster with one node.
> 2. Create a Ephemeral znode.
> 3. Change the system time of the ZooKeeper node to a earlier point.
> 4. Disconnect the client with the ZooKeeper server.
> Then the ephemeral znode will exist for a long time even when session tim=
eout.
> I have read the ZooKeeper source code and I find the code int SessionTrac=
kerImpl.java=EF=BC=8C
> {code:title=3DSessionTrackerImpl.java|borderStyle=3Dsolid}
>     @Override
>     synchronized public void run() {
>         try {
>             while (running) {
>                 currentTime =3D System.currentTimeMillis();
>                 if (nextExpirationTime > currentTime) {
>                     this.wait(nextExpirationTime - currentTime);
>                     continue;
>                 }
>                 SessionSet set;
>                 set =3D sessionSets.remove(nextExpirationTime);
>                 if (set !=3D null) {
>                     for (SessionImpl s : set.sessions) {
>                         setSessionClosing(s.sessionId);
>                         expirer.expire(s);
>                     }
>                 }
>                 nextExpirationTime +=3D expirationInterval;
>             }
>         } catch (InterruptedException e) {
>             handleException(this.getName(), e);
>         }
>         LOG.info("SessionTrackerImpl exited loop!");
>     }
> {code}
> I think it may be better to use System.nanoTime(), not System.currentTime=
Millis, because the later can be changed manually or automatically by a NTP=
 client.=20


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)