Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C6CA6200CA5 for ; Sat, 27 May 2017 01:05:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C54D1160BD9; Fri, 26 May 2017 23:05:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1877C160B9C for ; Sat, 27 May 2017 01:05:09 +0200 (CEST) Received: (qmail 14905 invoked by uid 500); 26 May 2017 23:05:08 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 14883 invoked by uid 99); 26 May 2017 23:05:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 May 2017 23:05:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 421D81889FD for ; Fri, 26 May 2017 23:05:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GmASAk54lU2X for ; Fri, 26 May 2017 23:05:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B37FC60D87 for ; Fri, 26 May 2017 23:05:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9FB26E0DD4 for ; Fri, 26 May 2017 23:05:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0F41021B57 for ; Fri, 26 May 2017 23:05:05 +0000 (UTC) Date: Fri, 26 May 2017 23:05:05 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ZOOKEEPER-2767) Correct the exception messages in X509Util if truststore location or password is not configured MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 26 May 2017 23:05:11 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2767. ------------------------------------ Resolution: Fixed Fix Version/s: 3.5.4 3.6.0 Issue resolved by pull request 263 [https://github.com/apache/zookeeper/pull/263] > Correct the exception messages in X509Util if truststore location or password is not configured > ----------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2767 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server > Affects Versions: 3.5.4, 3.6.0 > Reporter: Abhishek Kumar > Priority: Trivial > Fix For: 3.6.0, 3.5.4 > > > In org.apache.zookeeper.common.X509Util.org.apache.zookeeper.common.X509Util.createSSLContext exception messages contains keystore related messages instead of truststore messages for truststore location/password checks: > {noformat} > if (trustStoreLocationProp == null && trustStorePasswordProp == null) { > LOG.warn("keystore not specified for client connection"); > } else { > if (trustStoreLocationProp == null) { > throw new SSLContextException("keystore location not specified for client connection"); > } > if (trustStorePasswordProp == null) { > throw new SSLContextException("keystore password not specified for client connection"); > } > try { > trustManagers = new TrustManager[]{ > createTrustManager(trustStoreLocationProp, trustStorePasswordProp)}; > } catch (TrustManagerException e) { > throw new SSLContextException("Failed to create KeyManager", e); > } > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)