Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 15C22200C80 for ; Thu, 25 May 2017 12:41:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 142C9160BCA; Thu, 25 May 2017 10:41:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 33653160BC7 for ; Thu, 25 May 2017 12:41:08 +0200 (CEST) Received: (qmail 14546 invoked by uid 500); 25 May 2017 10:41:07 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 14529 invoked by uid 99); 25 May 2017 10:41:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 10:41:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BB2E8C0027 for ; Thu, 25 May 2017 10:41:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1Jdq__YP6ZJ7 for ; Thu, 25 May 2017 10:41:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C60555FB2C for ; Thu, 25 May 2017 10:41:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4ACA4E02C8 for ; Thu, 25 May 2017 10:41:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0FF2A21B57 for ; Thu, 25 May 2017 10:41:04 +0000 (UTC) Date: Thu, 25 May 2017 10:41:04 +0000 (UTC) From: "Janek P (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2730) Cleanup findbug warnings in branch-3.4: Internationalization Warnings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 25 May 2017 10:41:09 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024515#comment-16024515 ] Janek P commented on ZOOKEEPER-2730: ------------------------------------ I have two questions: 1) my idea is to define everywhere the encoding to be 'UTF-8'. WDYT, is it the right approach? Any issues that this might cause for consumers of the generated files (I am thinking in particular about 'jute') 2) which version of FindBugs are you using? There is none included with the project. I would like to have matching distribution. > Cleanup findbug warnings in branch-3.4: Internationalization Warnings > --------------------------------------------------------------------- > > Key: ZOOKEEPER-2730 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2730 > Project: ZooKeeper > Issue Type: Sub-task > Reporter: Rakesh R > Fix For: 3.4.11 > > > Please refer the attached sheet in parent jira. Below is the details of findbug warnings. > {code} > Dm Found reliance on default encoding in org.apache.jute.compiler.CGenerator.genCode(): new java.io.FileWriter(File) > Dm Found reliance on default encoding in org.apache.jute.compiler.CppGenerator.genCode(): new java.io.FileWriter(File) > Dm Found reliance on default encoding in org.apache.jute.compiler.JRecord.genCsharpCode(File): new java.io.FileWriter(File) > Dm Found reliance on default encoding in org.apache.jute.compiler.JRecord.genJavaCode(File): new java.io.FileWriter(File) > Dm Found reliance on default encoding in new org.apache.jute.XmlOutputArchive(OutputStream): new java.io.PrintStream(OutputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(String, int, String, int): new java.io.InputStreamReader(InputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(String, int, String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ClientCnxn$SendThread.pingRwServer(): new java.io.InputStreamReader(InputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.ClientCnxn$SendThread.pingRwServer(): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.auth.DigestAuthenticationProvider.generateDigest(String): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.auth.DigestAuthenticationProvider.handleAuthentication(ServerCnxn, byte[]): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.server.DataTree.updateBytes(String, long): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.server.DataTree.updateBytes(String, long): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.DataTree.updateCount(String, int): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.server.DataTree.updateCount(String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.DataTree.updateQuotaForPath(String): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.NettyServerCnxn$SendBufferWriter.checkFlush(boolean): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(boolean): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.persistence.FileSnap.(): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.persistence.FileTxnLog.(): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.quorum.QuorumPeer.readLongFromFile(String): new java.io.FileReader(File) > Dm Found reliance on default encoding in org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(String, long): new java.io.OutputStreamWriter(OutputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.server.quorum.QuorumPeerConfig.parseProperties(Properties): new java.io.FileReader(File) > Dm Found reliance on default encoding in org.apache.zookeeper.server.Request.toString(): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.server.ServerCnxn.(): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.server.TraceFormatter.main(String[]): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.server.util.OSMXBean.getMaxFileDescriptorCount(): new java.io.InputStreamReader(InputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.server.util.OSMXBean.getOpenFileDescriptorCount(): new java.io.InputStreamReader(InputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.dump(String, int): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.dump(String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.getTraceMask(String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.kill(String, int): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.kill(String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.ruok(String, int): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.ruok(String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.setTraceMask(String, int, String): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.stat(String, int): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ServerAdminClient.stat(String, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.Shell.runCommand(): new java.io.InputStreamReader(InputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.version.util.VerGen.generateFile(File, VerGen$Version, String, String): new java.io.FileWriter(File) > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.createQuota(ZooKeeper, String, long, int): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.createQuota(ZooKeeper, String, long, int): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.delQuota(ZooKeeper, String, boolean, boolean): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.delQuota(ZooKeeper, String, boolean, boolean): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain$MyCommandOptions): new String(byte[]) > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain$MyCommandOptions): String.getBytes() > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain.run(): new java.io.InputStreamReader(InputStream) > Dm Found reliance on default encoding in org.apache.zookeeper.ZooKeeperMain$1.processResult(int, String, Object, byte[], Stat): new String(byte[]) > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)