Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: asdf2014 <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-257-zookeeper@git.apache.org>
In-Reply-To: <git-pr-257-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...
Content-Type: text/plain
Message-Id: <20170520025545.0C32EDFC8B@git1-us-west.apache.org>
Date: Sat, 20 May 2017 02:55:45 +0000 (UTC)
archived-at: Sat, 20 May 2017 02:55:52 -0000

Github user asdf2014 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/257#discussion_r117600411
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -677,6 +686,7 @@ public void run() {
                         LOG.debug("Error closing server socket", ie);
                     }
                 }
    +            if (ce !=null) throw new RuntimeException(ce);
    --- End diff --
    
    Thx a lot! I will using `finally` deal with closing `socket`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---