Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-257-zookeeper@git.apache.org>
In-Reply-To: <git-pr-257-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper issue #257: ZOOKEEPER-2784: Add same `sid` config problem check
Content-Type: text/plain
Message-Id: <20170518233632.0CAF7DFF17@git1-us-west.apache.org>
Date: Thu, 18 May 2017 23:36:32 +0000 (UTC)
archived-at: Thu, 18 May 2017 23:36:39 -0000

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/257
  
    @asdf2014 : There are lots of formatting changes in this patch, which makes review harder.  Can you please update the patch to avoid those formatting changes? See [How To Contribute](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute):
    
    ## Please don't do in pull request:
    reformat code unrelated to the bug being fixed: formatting changes should be separate patches/commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---