Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: afine <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-236-zookeeper@git.apache.org>
In-Reply-To: <git-pr-236-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...
Content-Type: text/plain
Message-Id: <20170518202626.85CD8DFF93@git1-us-west.apache.org>
Date: Thu, 18 May 2017 20:26:26 +0000 (UTC)
archived-at: Thu, 18 May 2017 20:26:30 -0000

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/236#discussion_r117345541
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
    @@ -135,6 +135,8 @@ protected void processPacket(QuorumPacket qp) throws IOException{
             case Leader.SYNC:
                 fzk.sync();
                 break;
    +        default:
    +            LOG.error("Invalid packet type received by Observer: " + qp.getType());
    --- End diff --
    
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---