Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: rakeshadr <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-236-zookeeper@git.apache.org>
In-Reply-To: <git-pr-236-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...
Content-Type: text/plain
Message-Id: <20170518155826.1CE6AE112D@git1-us-west.apache.org>
Date: Thu, 18 May 2017 15:58:26 +0000 (UTC)
archived-at: Thu, 18 May 2017 15:58:29 -0000

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/236#discussion_r117285488
  
    --- Diff: src/java/main/org/apache/zookeeper/server/upgrade/UpgradeMain.java ---
    @@ -113,16 +113,18 @@ private void createAllDirs() throws IOException {
          * @throws IOException
          */
         void copyFiles(File srcDir, File dstDir, String filter) throws IOException {
    -        File[] list = srcDir.listFiles();
    -        for (File file: list) {
    -            String name = file.getName();
    -            if (name.startsWith(filter)) {
    -                // we need to copy this file
    -                File dest = new File(dstDir, name);
    -                LOG.info("Renaming " + file + " to " + dest);
    -                if (!file.renameTo(dest)) {
    -                    throw new IOException("Unable to rename " 
    -                            + file + " to " +  dest);
    +        File[] list;
    +        if ((list = srcDir.listFiles()) != null) {
    --- End diff --
    
    Please keep var assignment `(list = srcDir.listFiles())` along with the object reference.
    
    `File[] list = srcDir.listFiles();`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---