zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Fine (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2795) Can we make the ZookeeperServerShutdownHandler constructor public
Date Tue, 30 May 2017 20:04:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030037#comment-16030037

Abraham Fine commented on ZOOKEEPER-2795:

Hi [~achambers.home@gmail.com]-

Is your motivation for requesting this change related only to the undesirable log messages
or is there a functional reason for this change?

In general, we tend to err on the side of limited API exposure. The log level for the message
that you brought up is ERROR, which is pretty high in my opinion. Would you see changing the
log level as an acceptable solution to this problem?


> Can we make the ZookeeperServerShutdownHandler constructor public
> -----------------------------------------------------------------
>                 Key: ZOOKEEPER-2795
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
>             Project: ZooKeeper
>          Issue Type: Wish
>            Reporter: Andy Chambers
>            Priority: Trivial
> We have an integration test suite that starts up an embedded version of zookeeper as
part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of warnings that
look like this
> 17-05-30 15:04:56 achambers.local ERROR [org.apache.zookeeper.server.ZooKeeperServer:472]
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR
or SHUTDOWN server state changes
> My java is a bit rusty but I think I can't create one of these shutdown handlers from
outside the "org.apache.zookeeper.server" package because the constructor has not been marked
"public". Would it be possible to do so?

This message was sent by Atlassian JIRA

View raw message