zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode
Date Fri, 19 May 2017 19:18:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017880#comment-16017880

ASF GitHub Bot commented on ZOOKEEPER-2786:

GitHub user afine opened a pull request:


    ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

    On branch 3.4 we attempt to check that an invalid opcode in a request causes the server
to disconnect the client with:
            try {
                zk.exists("/m1", false);
                fail("The connection should have been closed");
            } catch (KeeperException.ConnectionLossException expected) {
    This can run into a race with the reconnection logic in `ClientCnxn.java`https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/ClientCnxn.java#L1052
We should use a watcher instead to track disconnects.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2786

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #260


> Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode
> ----------------------------------------------------------------------
>                 Key: ZOOKEEPER-2786
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2786
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
> This test is broken on 3.4 and 3.5, but is broken in "different" ways. Please see the
individual pull requests for detailed descriptions for the issues faced in both branches.

This message was sent by Atlassian JIRA

View raw message