zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2785) Server inappropriately throttles connections under load before SASL completes
Date Wed, 17 May 2017 08:24:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013719#comment-16013719
] 

Hadoop QA commented on ZOOKEEPER-2785:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/694//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/694//console

This message is automatically generated.

> Server inappropriately throttles connections under load before SASL completes
> -----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2785
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2785
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.10
>            Reporter: Abhishek Singh Chouhan
>            Priority: Critical
>             Fix For: 3.4.11
>
>
> When a zk server is running close to its outstanding requests limit, the server incorrectly
throttles the sasl request. This leads to the client waiting for the final sasl packet (session
is already established) and deferring all non priming packets till then which also includes
the ping packets. The client then waits for the final packet but never gets it and times out
saying haven't heard from server. This is fatal for services such as HBase which retry for
finite attempts and exit post these attempts.
> Issue being that in ZooKeeperServer.processPacket(..) incase of sasl we send the response
and incorrectly also call cnxn.incrOutstandingRequests(h), which throttles the connection
if we're running over outstandingrequests limit, which results in the server not processing
the subsequent packet from the client. Also we donot have any pending request to send for
the connection and hence never call enableRecv(). We should return after sending response
to the sasl request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message