zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem
Date Fri, 19 May 2017 17:37:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017727#comment-16017727
] 

ASF GitHub Bot commented on ZOOKEEPER-2784:
-------------------------------------------

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/257#discussion_r117528337
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock, Long sid) {
          * possible long value to lose the challenge.
          *
          */
    -    public void receiveConnection(Socket sock) {
    -        Long sid = null, protocolVersion = null;
    +    public void receiveConnection(Socket sock) throws ConfigException {
    +        Long sid, protocolVersion;
    --- End diff --
    
    As we removed the extraneous `null` here we could also use the primitive long type, right?
I don't see any gain of using boxed types here. I see a lot of boxing/unboxing down in this
method, so it could be simply `int sid, protocolVersion;` (this slightly falls into "the don't
fix if..." adage, but we can ignore this for once ;) ).


> Add some limitations on code level for `SID` to avoid configuration problem
> ---------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2784
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>    Affects Versions: 3.5.2
>            Reporter: Benedict Jin
>             Fix For: 3.6.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> As so far, `QuorumCnxManager#receiveConnection` cannot find out the same `SID` problem,
then the Zookeeper cluster will start successfully. But the cluster is not health, and it
will throw some problem like `not synchronized`. So, i thought we should add some limitations
on code level for `SID` to find those configuration problem more early.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message