zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem
Date Thu, 18 May 2017 23:37:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016660#comment-16016660

ASF GitHub Bot commented on ZOOKEEPER-2784:

Github user hanm commented on the issue:

    @asdf2014 : There are lots of formatting changes in this patch, which makes review harder.
 Can you please update the patch to avoid those formatting changes? See [How To Contribute](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute):
    ## Please don't do in pull request:
    reformat code unrelated to the bug being fixed: formatting changes should be separate

> Add some limitations on code level for `SID` to avoid configuration problem
> ---------------------------------------------------------------------------
>                 Key: ZOOKEEPER-2784
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>    Affects Versions: 3.5.2
>            Reporter: Benedict Jin
>             Fix For: 3.6.0
>   Original Estimate: 168h
>  Remaining Estimate: 168h
> As so far, `QuorumCnxManager#receiveConnection` cannot find out the same `SID` problem,
then the Zookeeper cluster will start successfully. But the cluster is not health, and it
will throw some problem like `not synchronized`. So, i thought we should add some limitations
on code level for `SID` to find those configuration problem more early.

This message was sent by Atlassian JIRA

View raw message