zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2767) Correct the exception messages in X509Util if truststore location or password is not configured
Date Wed, 24 May 2017 05:45:05 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022343#comment-16022343
] 

Hadoop QA commented on ZOOKEEPER-2767:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/740//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/740//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/740//console

This message is automatically generated.

> Correct the exception messages in X509Util if truststore location or password is not
configured
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2767
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2767
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client, server
>    Affects Versions: 3.5.4, 3.6.0
>            Reporter: Abhishek Kumar
>            Priority: Trivial
>
> In org.apache.zookeeper.common.X509Util.org.apache.zookeeper.common.X509Util.createSSLContext
exception messages contains keystore related messages instead of truststore messages for truststore
location/password checks:
> {noformat}
> if (trustStoreLocationProp == null && trustStorePasswordProp == null) {
>             LOG.warn("keystore not specified for client connection");
>         } else {
>             if (trustStoreLocationProp == null) {
>                 throw new SSLContextException("keystore location not specified for client
connection");
>             }
>             if (trustStorePasswordProp == null) {
>                 throw new SSLContextException("keystore password not specified for client
connection");
>             }
>             try {
>                 trustManagers = new TrustManager[]{
>                         createTrustManager(trustStoreLocationProp, trustStorePasswordProp)};
>             } catch (TrustManagerException e) {
>                 throw new SSLContextException("Failed to create KeyManager", e);
>             }
>         }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message