zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2762) Multithreaded correctness Warnings
Date Mon, 22 May 2017 09:08:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019327#comment-16019327
] 

ASF GitHub Bot commented on ZOOKEEPER-2762:
-------------------------------------------

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/239#discussion_r117696607
  
    --- Diff: src/java/test/config/findbugsExcludeFile.xml ---
    @@ -90,6 +90,16 @@
          <Bug code="IS"/>
       </Match>
       <Match>
    +    <Class name="org.apache.zookeeper.server.quorum.Leader"/>
    +    <Method name="lead"/>
    --- End diff --
    
    Following are the variables, reported for MultiThreadedCorrectness warnings.
    ```
    QuorumPeer.tick
    FastLeaderElection.logicalclock
    AuthFastLeaderElection.logicalclock
    ```
    
    How about using `AtomicLong & AtomicLong` instead of excluding. Please refer branch-3.5
or trunk code as a reference.
    
    ```
    AtomicLong logicalclock = new AtomicLong(); /* Election instance */
    AtomicInteger tick = new AtomicInteger();
    ```


> Multithreaded correctness Warnings
> ----------------------------------
>
>                 Key: ZOOKEEPER-2762
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2762
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>             Fix For: 3.4.11
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message