zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
Date Tue, 23 May 2017 23:25:08 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022069#comment-16022069
] 

ASF GitHub Bot commented on ZOOKEEPER-2684:
-------------------------------------------

GitHub user nerdyyatrice reopened a pull request:

    https://github.com/apache/zookeeper/pull/167

    ZOOKEEPER-2684 commitProcessor does not crash when an unseen commit somes

    commitProcessor with the zookeeper-2024 improvement patch throws an exception when it
sees a commit request that is not at the queue head.  It turned out that it is actually a
valid case when there is session movement. After discussion with the community, I submit this
pull request to mitigate this issue by passing those commits to the next processor instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nerdyyatrice/zookeeper zookeeper-2684

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #167
    
----
commit 423e385038d055b034a71e91a503ff31532e84a2
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-10T01:33:23Z

    commitProcessor does not crash when an unseen commit somes

commit cde12800a4ddecce26d41a4870cd19ae8d7e6f15
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-10T02:24:19Z

    commitProcessor does not crash when an unseen commit somes

commit 0f7c2e815c3744d8088f12b6e802365ab164ff9a
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-16T20:53:56Z

    remove the exception in the commit processor as commit requests can arrive out of order
in terms of CXid

commit d80b715620bbbef173be4acbeb022892ff13934d
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-16T20:59:34Z

    Merge branch 'zookeeper-2684' of https://github.com/nerdyyatrice/zookeeper into zookeeper-2684

commit 61f4764b51c92d93cdf5b63ab617efa41e1ee44c
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-16T23:45:06Z

    adjust the test and to re-kick the submit

commit 5191fa83eb88967e91fc7df4c18a106369b0dd0c
Author: rzhang <rzhang@twitter.com>
Date:   2017-04-21T00:18:51Z

     ZOOKEEPER-2684: Fix a crashing bug in the mixed workloads commit processor

commit fde3b0eba781361e5775445ecc6cfd20efe71f05
Author: rzhang <rzhang@twitter.com>
Date:   2017-04-21T22:38:07Z

    ZOOKEEPER-2684: Fix a crashing bug in the mixed workloads commit processor

----


> Fix a crashing bug in the mixed workloads commit processor
> ----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2684
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.6.0
>         Environment: with pretty heavy load on a real cluster
>            Reporter: Ryan Zhang
>            Assignee: Ryan Zhang
>            Priority: Blocker
>         Attachments: ZOOKEEPER-2684.patch
>
>
> We deployed our build with ZOOKEEPER-2024 and it quickly started to crash with the following
error
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR [CommitProcessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
– Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR [CommitProcessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
– Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR [CommitProcessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
– Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR [CommitProcessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
– Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc
> clearly something is not right in the new commit processor per session queue implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message