zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #249: [ZOOKEEPER-2779] Branch 3.5 backport
Date Tue, 30 May 2017 23:32:06 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/249#discussion_r119240556
  
    --- Diff: src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml ---
    @@ -338,7 +338,10 @@ server.3=125.23.63.25:2782:2785:participant</programlisting>
             environment (i.e. behind company firewall). For those users who want to use reconfiguration
feature but
             don't want the overhead of configuring an explicit list of authorized user for
reconfig access checks,
             they can set <ulink url="zookeeperAdmin.html#sc_authOptions">"skipACL"</ulink>
to "yes" which will
    -        skip ACL check and allow any user to reconfigure cluster.
    +        skip ACL check and allow any user to reconfigure cluster. A more secure mechanism
is also provided.
    --- End diff --
    
    Please remove the "A more secure mechanism is also provided." This approach is no safer
than the offline superuser approach per discussion in JIRA. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message