zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #248: [ZOOKEEPER-2779] Provide a means to disable set...
Date Tue, 30 May 2017 18:21:24 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/248#discussion_r119176943
  
    --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
    @@ -254,12 +262,14 @@ public void addConfigNode() {
             }
     
             nodes.put(configZookeeper, configDataNode);
    -        try {
    -            // Reconfig node is access controlled by default (ZOOKEEPER-2014).
    -            setACL(configZookeeper, ZooDefs.Ids.READ_ACL_UNSAFE, -1);
    -        } catch (KeeperException.NoNodeException e) {
    -            assert false : "There's no " + configZookeeper +
    -                    " znode - this should never happen.";
    +        if ( !skipDefaultACLForReconfig ) {
    --- End diff --
    
    nit: no spaces around the condition


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message