zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nerdyyatrice <...@git.apache.org>
Subject [GitHub] zookeeper pull request #167: ZOOKEEPER-2684 commitProcessor does not crash w...
Date Tue, 23 May 2017 23:24:14 GMT
GitHub user nerdyyatrice reopened a pull request:

    https://github.com/apache/zookeeper/pull/167

    ZOOKEEPER-2684 commitProcessor does not crash when an unseen commit somes

    commitProcessor with the zookeeper-2024 improvement patch throws an exception when it
sees a commit request that is not at the queue head.  It turned out that it is actually a
valid case when there is session movement. After discussion with the community, I submit this
pull request to mitigate this issue by passing those commits to the next processor instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nerdyyatrice/zookeeper zookeeper-2684

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #167
    
----
commit 423e385038d055b034a71e91a503ff31532e84a2
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-10T01:33:23Z

    commitProcessor does not crash when an unseen commit somes

commit cde12800a4ddecce26d41a4870cd19ae8d7e6f15
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-10T02:24:19Z

    commitProcessor does not crash when an unseen commit somes

commit 0f7c2e815c3744d8088f12b6e802365ab164ff9a
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-16T20:53:56Z

    remove the exception in the commit processor as commit requests can arrive out of order
in terms of CXid

commit d80b715620bbbef173be4acbeb022892ff13934d
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-16T20:59:34Z

    Merge branch 'zookeeper-2684' of https://github.com/nerdyyatrice/zookeeper into zookeeper-2684

commit 61f4764b51c92d93cdf5b63ab617efa41e1ee44c
Author: rzhang <rzhang@twitter.com>
Date:   2017-02-16T23:45:06Z

    adjust the test and to re-kick the submit

commit 5191fa83eb88967e91fc7df4c18a106369b0dd0c
Author: rzhang <rzhang@twitter.com>
Date:   2017-04-21T00:18:51Z

     ZOOKEEPER-2684: Fix a crashing bug in the mixed workloads commit processor

commit fde3b0eba781361e5775445ecc6cfd20efe71f05
Author: rzhang <rzhang@twitter.com>
Date:   2017-04-21T22:38:07Z

    ZOOKEEPER-2684: Fix a crashing bug in the mixed workloads commit processor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message