zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...
Date Mon, 22 May 2017 07:28:16 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/236#discussion_r117673526
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -628,14 +628,7 @@ protected void pRequest(Request request) throws RequestProcessorException
{
                     break;
      
                 //All the rest don't need to create a Txn - just verify session
    -            case OpCode.sync:
    -            case OpCode.exists:
    -            case OpCode.getData:
    -            case OpCode.getACL:
    -            case OpCode.getChildren:
    -            case OpCode.getChildren2:
    -            case OpCode.ping:
    -            case OpCode.setWatches:
    +            default:
    --- End diff --
    
    Thanks @afine for the detailed explanation. Yes, I'd prefer to keep the code in sync with
branch-3.5/trunk. Also, this way, protects the code irrespective of upper layer code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message