zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...
Date Mon, 22 May 2017 04:06:21 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/232#discussion_r117658774
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
    @@ -96,21 +97,20 @@
             /**
              * This is a completely open ACL .
              */
    -        public final ArrayList<ACL> OPEN_ACL_UNSAFE = new ArrayList<ACL>(
    -                Collections.singletonList(new ACL(Perms.ALL, ANYONE_ID_UNSAFE)));
    +        public final List<ACL> OPEN_ACL_UNSAFE =
    +                Collections.singletonList(new ACL(Perms.ALL, ANYONE_ID_UNSAFE));
     
             /**
              * This ACL gives the creators authentication id's all permissions.
              */
    -        public final ArrayList<ACL> CREATOR_ALL_ACL = new ArrayList<ACL>(
    -                Collections.singletonList(new ACL(Perms.ALL, AUTH_IDS)));
    +        public final List<ACL> CREATOR_ALL_ACL =
    --- End diff --
    
    Same as above, typically we won't modify the exposed APIs in 3.4.* releases. Its OK to
exclude this case as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message