zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...
Date Fri, 19 May 2017 20:25:21 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/257#discussion_r117565984
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -677,6 +686,7 @@ public void run() {
                         LOG.debug("Error closing server socket", ie);
                     }
                 }
    +            if (ce !=null) throw new RuntimeException(ce);
    --- End diff --
    
    Would it be possible to refactor this so the exception never leaves its catch block? Perhaps
the logic "in between" can be captured with "finally". Then I think we will fix https://github.com/apache/zookeeper/pull/257/files#r117407300
as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message