zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...
Date Fri, 19 May 2017 17:37:04 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/257#discussion_r117407300
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -657,9 +663,12 @@ public void run() {
                             LOG.error("Error closing server socket", ie);
                         } catch (InterruptedException ie) {
                             LOG.error("Interrupted while sleeping. " +
    -                            "Ignoring exception", ie);
    +                                "Ignoring exception", ie);
                         }
                         closeSocket(client);
    +                } catch (ConfigException e) {
    +                    LOG.error(e.getMessage());
    +                    ce = e;
    --- End diff --
    
    :+1: BUT you need to call `closeSocket(client);` here too. See line 668. ;) It is the
ServerSocket and Socket we need to close in case of error. I know we close the socket previously
before throwing the exception, but `Socket#close()` is idempotent so, I would advise to put
it here too. In fact, we could remove line 668 and add a `finally` block with the  `closeSocket(client);`
after line 672.
    
    **Most important!** The latest change doesn't break the while loop so it only leave after
reaching the maximum number of retries or shutdown is called (I bet the first). We should
include a `break;` at line 672. ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message