zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...
Date Fri, 19 May 2017 17:37:04 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/257#discussion_r117528337
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock, Long sid) {
          * possible long value to lose the challenge.
          *
          */
    -    public void receiveConnection(Socket sock) {
    -        Long sid = null, protocolVersion = null;
    +    public void receiveConnection(Socket sock) throws ConfigException {
    +        Long sid, protocolVersion;
    --- End diff --
    
    As we removed the extraneous `null` here we could also use the primitive long type, right?
I don't see any gain of using boxed types here. I see a lot of boxing/unboxing down in this
method, so it could be simply `int sid, protocolVersion;` (this slightly falls into "the don't
fix if..." adage, but we can ignore this for once ;) ).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message