zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...
Date Thu, 18 May 2017 15:58:26 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/236#discussion_r117287341
  
    --- Diff: ivy.xml ---
    @@ -49,6 +49,8 @@
         <dependency org="log4j" name="log4j" rev="1.2.16" transitive="false" conf="default"/>
         <dependency org="jline" name="jline" rev="0.9.94" transitive="false" conf="default"/>
     
    +    <dependency org="com.google.code.findbugs" name="annotations" rev="3.0.1" conf="default"/>
    --- End diff --
    
    I'd prefer to exclude `AuthFastLeaderElection.java` as this is deprecated rather than
introducing google library dependency. Does this sound good to you. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message