zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...
Date Thu, 18 May 2017 15:58:25 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/236#discussion_r117279935
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -628,14 +628,7 @@ protected void pRequest(Request request) throws RequestProcessorException
{
                     break;
      
                 //All the rest don't need to create a Txn - just verify session
    -            case OpCode.sync:
    -            case OpCode.exists:
    -            case OpCode.getData:
    -            case OpCode.getACL:
    -            case OpCode.getChildren:
    -            case OpCode.getChildren2:
    -            case OpCode.ping:
    -            case OpCode.setWatches:
    +            default:
    --- End diff --
    
    This will execute if any `unknown type` and is not expected, isn't it?
    We could keep the existing case checks and add default like,
    ```
                    zks.sessionTracker.checkSession(request.sessionId,
                              request.getOwner());
                    break;
                default:
                    LOG.warn("unknown type " + request.type);
                    break;
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message