zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...
Date Thu, 18 May 2017 15:58:25 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/236#discussion_r117283048
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java ---
    @@ -133,11 +133,17 @@ public boolean accept(File f){
                 }
             }
             // add all non-excluded log files
    -        List<File> files = new ArrayList<File>(Arrays.asList(txnLog
    -                .getDataDir().listFiles(new MyFileFilter(PREFIX_LOG))));
    +        List<File> files = new ArrayList<File>();
    +        File[] fileArray;
    +        if ((fileArray = txnLog.getDataDir().listFiles(new MyFileFilter(PREFIX_LOG)))
!= null) {
    +            files.addAll(Arrays.asList(fileArray));
    +        }
    +
             // add all non-excluded snapshot files to the deletion list
    -        files.addAll(Arrays.asList(txnLog.getSnapDir().listFiles(
    -                new MyFileFilter(PREFIX_SNAPSHOT))));
    +        if ((fileArray = txnLog.getSnapDir().listFiles(new MyFileFilter(PREFIX_SNAPSHOT)))
!= null) {
    --- End diff --
    
    Same as above, Its good to keep the var assignment outside if check for better readability.
    `(fileArray = txnLog.getSnapDir().listFiles(new MyFileFilter(PREFIX_SNAPSHOT))`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message