zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arshadmohammad <...@git.apache.org>
Subject [GitHub] zookeeper pull request #254: ZOOKEEPER-2775: ZK Client not able to connect w...
Date Wed, 17 May 2017 14:29:45 GMT
Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/254#discussion_r117016986
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1054,6 +1054,8 @@ private void sendPing() {
             private boolean saslLoginFailed = false;
     
             private void startConnect() throws IOException {
    +            // initializing it for new connection
    +            saslLoginFailed = false;
    --- End diff --
    
    Successfull Login is not necessary to successfully connect to ZK Server.  ZK server may
allow connection without client login being successful, based on configuration. So it is better
to set the flag at the start of the new connection.  
    This change has impact on tunnelAuthInProgress, in this method also same thing is expeted.
In this there is a sceanrio where zooKeeperSaslClient can be null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message