zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andschwa <...@git.apache.org>
Subject [GitHub] zookeeper issue #255: ZOOKEEPER-2756: Add CMake build system for better cros...
Date Tue, 16 May 2017 18:41:55 GMT
Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/255
  
    @hanm I was proposing we replace the existing sln/vcproj/vcxproj entirely, as they can
be built for any version of VS using CMake. I could record their deletion in this PR even.
We _could_ keep them and retain compatibility with them, but it'd be ugly, as they rely on
the manually generated portion of `winconfig.h` which I replaced with the auto-generated `config.h`.
What do you think?
    
    Also, I'm not super comfortable including the changes in 065056b0b240b7bdff2eebe41db86a9a3ea6ecfc
, your thoughts? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message