zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #173: ZOOKEEPER-2691: recreateSocketAddresses may rec...
Date Tue, 16 May 2017 16:55:44 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/173#discussion_r116798516
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -198,6 +246,12 @@ public void recreateSocketAddresses() {
             public long id;
             
             public LearnerType type = LearnerType.PARTICIPANT;
    +
    +        /**
    +         * the time, in milliseconds, before {@link InetAddress#isReachable} aborts
    +         * in {@link #getReachableAddress}.
    +         */
    +        private int ipReachableTimeout = 0;
    --- End diff --
    
    I think we can remove this. This will also remove the four copies of exact same initialization
code fragment that you use to initialize the value. We can get the sys property and parse
the value inside recreateSocketAddress directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message