zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #252: ZOOKEEPER-2772: Delete node command does not ho...
Date Sat, 13 May 2017 05:52:58 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/252#discussion_r116351552
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -389,8 +389,8 @@ protected void pRequest2Txn(int type, long zxid, Request request,
Record record,
                     parentPath = path.substring(0, lastSlash);
                     parentRecord = getRecordForPath(parentPath);
                     ChangeRecord nodeRecord = getRecordForPath(path);
    -                checkACL(zks, parentRecord.acl, ZooDefs.Perms.DELETE,
    -                        request.authInfo);
    +                checkACL(zks, parentRecord.acl, ZooDefs.Perms.DELETE, request.authInfo);
    --- End diff --
    
    I see that when we create a znode we need to check the ACL of the parent. But do we still
need to check the parent when we are deleting? /cc @phunt @fpj 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message