Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6491C200C6E for ; Mon, 24 Apr 2017 07:09:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 63200160BB1; Mon, 24 Apr 2017 05:09:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A9A0D160BA6 for ; Mon, 24 Apr 2017 07:09:09 +0200 (CEST) Received: (qmail 9472 invoked by uid 500); 24 Apr 2017 05:09:08 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 9458 invoked by uid 99); 24 Apr 2017 05:09:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Apr 2017 05:09:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 23774CF500 for ; Mon, 24 Apr 2017 05:09:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wP7UZV6Jxh_O for ; Mon, 24 Apr 2017 05:09:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 99A295FC4D for ; Mon, 24 Apr 2017 05:09:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B3BC8E0BD5 for ; Mon, 24 Apr 2017 05:09:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 326A821B56 for ; Mon, 24 Apr 2017 05:09:04 +0000 (UTC) Date: Mon, 24 Apr 2017 05:09:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2742) Few test cases of org.apache.zookeeper.ZooKeeperTest fails in Windows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 24 Apr 2017 05:09:10 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980730#comment-15980730 ] ASF GitHub Bot commented on ZOOKEEPER-2742: ------------------------------------------- Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/237 LGTM, +1 I will commit it soon. > Few test cases of org.apache.zookeeper.ZooKeeperTest fails in Windows > --------------------------------------------------------------------- > > Key: ZOOKEEPER-2742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2742 > Project: ZooKeeper > Issue Type: Test > Components: tests > Environment: Windows > Reporter: Abhishek Kumar > Priority: Trivial > Fix For: 3.5.4, 3.6.0 > > Attachments: ZOOKEEPER-2742-01.patch > > > Following test cases fail in Windows environment: > 1. org.apache.zookeeper.ZooKeeperTest.testLsrRootCommand() > 2. org.apache.zookeeper.ZooKeeperTest.testLsrCommand() > It seems that failure is related to use of "\n" (System dependent new line char)in org.apache.zookeeper.ZooKeeperTest.runCommandExpect(CliCommand, List) > ...................................... > ...................................... > String result = byteStream.toString(); > assertTrue(result, result.contains( > StringUtils.joinStrings(expectedResults, "\n"))); > ...................................... > ...................................... -- This message was sent by Atlassian JIRA (v6.3.15#6346)