Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1AA71200C72 for ; Fri, 28 Apr 2017 07:18:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 191EE160BB2; Fri, 28 Apr 2017 05:18:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5FFB1160BA7 for ; Fri, 28 Apr 2017 07:18:14 +0200 (CEST) Received: (qmail 82726 invoked by uid 500); 28 Apr 2017 05:18:08 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 82715 invoked by uid 99); 28 Apr 2017 05:18:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 05:18:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1907E1A04AC for ; Fri, 28 Apr 2017 05:18:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id CkwD5OLh4LEz for ; Fri, 28 Apr 2017 05:18:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 47B7B5FC4D for ; Fri, 28 Apr 2017 05:18:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 34A77E0D45 for ; Fri, 28 Apr 2017 05:18:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 412D321DE9 for ; Fri, 28 Apr 2017 05:18:04 +0000 (UTC) Date: Fri, 28 Apr 2017 05:18:04 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 28 Apr 2017 05:18:15 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988225#comment-15988225 ] Michael Han commented on ZOOKEEPER-2662: ---------------------------------------- [~eribeiro] Do you mind creating another PR for branch-3.5? I'll resolve this JIRA once this is merged to 3.5. > Export a metric for txn log sync times > -------------------------------------- > > Key: ZOOKEEPER-2662 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Andrew Purtell > Assignee: Edward Ribeiro > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2662.diff > > > In FileTxnLog there is code that records the amount of time required to fsync the txn log in order to warn if that time exceeds a configurable threshold. This information should also be exported as a metric available by JMX so an important aspect of quorum performance can be monitored. > ZooKeeperServerMXBean carries some global latency information for the server process already, seems like a good place to put it if not an entirely new bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same information for snapshots. -- This message was sent by Atlassian JIRA (v6.3.15#6346)