Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Tue, 11 Apr 2017 19:34:41 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12911065.1446820492000.259346.1491939281604@Atlassian.JIRA>
In-Reply-To: <JIRA.12911065.1446820492000@Atlassian.JIRA>
References: <JIRA.12911065.1446820492000@Atlassian.JIRA> <JIRA.12911065.1446820492718@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2316) comment does not match code
 logic
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 11 Apr 2017 19:34:46 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964857#comment-15964857 ] 

Hadoop QA commented on ZOOKEEPER-2316:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/533//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/533//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/533//console

This message is automatically generated.

> comment does not match code logic
> ---------------------------------
>
>                 Key: ZOOKEEPER-2316
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2316
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.1
>            Reporter: sunhaitao
>            Priority: Trivial
>             Fix For: 3.5.1
>
>
> when i read the code below, the comment is put in an incorrect,place.
> " // in order to be committed, a proposal must be accepted by a quorum "
> should be place on top of :
>    if (!p.hasAllQuorums()) {
>            return false;                 
>         }
> ---------------------------------------------------------------------------------------          
> 3.5.1 Leader code  
> // getting a quorum from all necessary configurations
>         if (!p.hasAllQuorums()) {
>            return false;                 
>         }
>         
>         // commit proposals in order
>         if (zxid != lastCommitted+1) {    
>            LOG.warn("Commiting zxid 0x" + Long.toHexString(zxid)
>                     + " from " + followerAddr + " not first!");
>             LOG.warn("First is "
>                     + (lastCommitted+1));
>         }     
>         
>         // in order to be committed, a proposal must be accepted by a quorum              
>         
>         outstandingProposals.remove(zxid);
>         


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)