Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Mon, 10 Apr 2017 20:06:42 +0000 (UTC)
From: "Umesh Panchaksharaiah (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12911065.1446820492000.250821.1491854802421@Atlassian.JIRA>
In-Reply-To: <JIRA.12911065.1446820492000@Atlassian.JIRA>
References: <JIRA.12911065.1446820492000@Atlassian.JIRA> <JIRA.12911065.1446820492718@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2316) comment does not match code
 logic
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Apr 2017 20:06:47 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963430#comment-15963430 ] 

Umesh Panchaksharaiah commented on ZOOKEEPER-2316:
--------------------------------------------------

Hi, Can you please assign this bug to me. I am wading into asf now and this may be a good first bug. Thanks

> comment does not match code logic
> ---------------------------------
>
>                 Key: ZOOKEEPER-2316
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2316
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.1
>            Reporter: sunhaitao
>            Priority: Trivial
>             Fix For: 3.5.1
>
>
> when i read the code below, the comment is put in an incorrect,place.
> " // in order to be committed, a proposal must be accepted by a quorum "
> should be place on top of :
>    if (!p.hasAllQuorums()) {
>            return false;                 
>         }
> ---------------------------------------------------------------------------------------          
> 3.5.1 Leader code  
> // getting a quorum from all necessary configurations
>         if (!p.hasAllQuorums()) {
>            return false;                 
>         }
>         
>         // commit proposals in order
>         if (zxid != lastCommitted+1) {    
>            LOG.warn("Commiting zxid 0x" + Long.toHexString(zxid)
>                     + " from " + followerAddr + " not first!");
>             LOG.warn("First is "
>                     + (lastCommitted+1));
>         }     
>         
>         // in order to be committed, a proposal must be accepted by a quorum              
>         
>         outstandingProposals.remove(zxid);
>         


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)