Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-222-zookeeper@git.apache.org>
In-Reply-To: <git-pr-222-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper issue #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeeper clie...
Content-Type: text/plain
Message-Id: <20170427171946.C8D77E01BC@git1-us-west.apache.org>
Date: Thu, 27 Apr 2017 17:19:46 +0000 (UTC)
archived-at: Thu, 27 Apr 2017 17:19:48 -0000

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/222
  
    Since we have this new close method we probably should remove the testableClose but it looks like there are also other testable* methods since 3.3.0 and we have to consider there are many folks already use this testable method (even not just in test code.). So it sounds good to me to keep the testable method as is and because of this it also sounds good to me to add the new close method to 3.5.
    
    I think what's remaining is some doc work:
    * Add @since tag in the new close method.
    * Would be good to some comments in the existing close() method mentioning that it does not release all threads internally used, and then link to the new close method added in this patch if users want certain behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---