Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: eolivelli <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-227-zookeeper@git.apache.org>
In-Reply-To: <git-pr-227-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSock...
Content-Type: text/plain
Message-Id: <20170426101214.667C3DFB94@git1-us-west.apache.org>
Date: Wed, 26 Apr 2017 10:12:14 +0000 (UTC)
archived-at: Wed, 26 Apr 2017 10:12:16 -0000

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/227#discussion_r113414288
  
    --- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java ---
    @@ -0,0 +1,35 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.test;
    +
    +import org.junit.runners.Suite;
    +
    +/**
    + * Run tests with: Netty Client against Netty server
    + */
    +@Suite.SuiteClasses({
    --- End diff --
    
    @afine Thank you for your review.
    I have addressed most of your comments (fix imports, duplicate code...)
    
    Regarding the tests, 
    It will be interesting in order to see that all the code can run cleanly without network.
    But IMHO a new system property/run time flag will add the need to run always twice the full suite at every build/release.
    I have added the least possible testcases to cover basic features so that future refactor will not drop the ability to use the Local Transport.
    At this moment I think it is not the time to add an official "local transport" netty connection factory.
    
    
    Regarding server-to-server communications:
    I can't find how to enable Netty for server-to-server communications, I will dig deeply into the code. It seems that the Learner class uses directly a Socket, so it is not possible to leverage Netty local transport feature. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---