Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: alburthoffman <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-238-zookeeper@git.apache.org>
In-Reply-To: <git-pr-238-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leadi...
Content-Type: text/plain
Message-Id: <20170426030442.2A7BFDFBDA@git1-us-west.apache.org>
Date: Wed, 26 Apr 2017 03:04:42 +0000 (UTC)
archived-at: Wed, 26 Apr 2017 03:04:46 -0000

Github user alburthoffman commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/238#discussion_r113356883
  
    --- Diff: src/java/main/org/apache/jute/Utils.java ---
    @@ -190,19 +190,32 @@ static String fromCSVString(String s) throws IOException {
         }
         
         /**
    +     * convert byte array to a string in hex format
          * 
    -     * @param s 
    -     * @return 
    +     * @param barr
    +     * @return
          */
    -    static String toXMLBuffer(byte barr[]) {
    --- End diff --
    
    you are right. printHexBinary works exactly as same as toHexString.
    I will change it to use printHexBinary and add test cases.
    
    Thx for ur suggestion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---