Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-184-zookeeper@git.apache.org>
In-Reply-To: <git-pr-184-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Content-Type: text/plain
Message-Id: <20170406010707.377ACDFDAC@git1-us-west.apache.org>
Date: Thu,  6 Apr 2017 01:07:07 +0000 (UTC)
archived-at: Thu, 06 Apr 2017 01:07:09 -0000

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r110061068
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -253,7 +255,10 @@ protected void connectToLeader(InetSocketAddress addr)
                         throw new IOException("initLimit exceeded on retries.");
                     }
     
    -                sockConnect(sock, addr, Math.min(self.tickTime * self.syncLimit, remainingInitLimitTime));
    +                sockConnect(sock, leader.addr, Math.min(self.tickTime * self.syncLimit, remainingInitLimitTime));
    --- End diff --
    
    leader could be null in leader.addr right? Still wondering why change the leader type from an address to a QuorumServer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---