Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-184-zookeeper@git.apache.org>
In-Reply-To: <git-pr-184-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Content-Type: text/plain
Message-Id: <20170406003219.540BBDFC8E@git1-us-west.apache.org>
Date: Thu,  6 Apr 2017 00:32:19 +0000 (UTC)
archived-at: Thu, 06 Apr 2017 00:32:26 -0000

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r110057806
  
    --- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
    @@ -0,0 +1,231 @@
    +/**
    --- End diff --
    
    This is supposed to be a test file, right? If so, test file should be under src/test folder. Does this even build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---