zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #233: ZOOKEEPER-2762: Multithreaded correctness Warni...
Date Tue, 18 Apr 2017 22:11:36 GMT
GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/233

    ZOOKEEPER-2762: Multithreaded correctness Warnings

    This patch adds the dependency required to suppress findbugs warnings.
    
    The warning we are trying to suppress in three locations is:
    VO_VOLATILE_INCREMENT: An increment to a volatile field isn't atomic
    This code increments a volatile field. Increments of volatile fields aren't atomic. If
more than one thread is incrementing the field at the same time, increments could be lost.
    
    The places where we increment a volatile field are either deprecated (which I do not think
we should fix), occur in a synchronized block, or are only ever executed by a single thread.
    
    In addition, this patch also fixes AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION: Sequence
of calls to concurrent abstraction may not be atomic in QuorumCnxManager.java.
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2762

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #233
    
----
commit 4ed09dddf905dfba590d4c410262689934a93f46
Author: Abraham Fine <afine@apache.org>
Date:   2017-04-18T22:00:53Z

    ZOOKEEPER-2762: Multithreaded correctness Warnings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message