zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #213: ZOOKEEPER-2746: remove the check on the new lea...
Date Tue, 04 Apr 2017 23:44:56 GMT
GitHub user hanm opened a pull request:

    https://github.com/apache/zookeeper/pull/213

    ZOOKEEPER-2746: remove the check on the new leader after a dynamic re…

    …config operation.
    
    This check might not always hold because the nominated leader could fail to lead the quorum
during sync phase - for example if sync time out [when waiting for quorum ack](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L1232).
I am thinking we should just remove this instead of fixing it because the nominated leader
is not an interface level contract / guarantee but a best effort / implementation level details.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2746

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #213
    
----
commit 9e367d6f46811233b4bac169f5abb58ff1777273
Author: Michael Han <hanm@apache.org>
Date:   2017-04-04T23:41:09Z

    ZOOKEEPER-2746: remove the check on the new leader after a dynamic reconfig operation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message