zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2765) modern C++ client
Date Wed, 19 Apr 2017 18:12:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975212#comment-15975212
] 

ASF GitHub Bot commented on ZOOKEEPER-2765:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/234#discussion_r112275679
  
    --- Diff: src/contrib/cppclient/DelegatingSessionEventWatcher.h ---
    @@ -0,0 +1,151 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#pragma once
    +
    +#include <folly/Synchronized.h>
    +#include <list>
    +#include <mutex>
    +#include "zeus/client/ZookeeperClient.h"
    --- End diff --
    
    Include here should be just "ZookeeperClient.h" (and there are a couple of other places
that involves zeus/client includes), since there is no zeus folder included as part of this
pr.


> modern C++ client
> -----------------
>
>                 Key: ZOOKEEPER-2765
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2765
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: c client
>            Reporter: Edward Carter
>            Assignee: Edward Carter
>
> We should add a modern C++ (i.e. C++14, C++17, etc.) client library that wraps the existing
C client.  A future issue may replace the C client itself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message