zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2747) Fix ZooKeeperAdmin Compilation Warning
Date Thu, 06 Apr 2017 22:20:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959887#comment-15959887

Hadoop QA commented on ZOOKEEPER-2747:

-1 overall.  GitHub Pull Request  Build

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/510//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/510//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/510//console

This message is automatically generated.

> Fix ZooKeeperAdmin Compilation Warning
> --------------------------------------
>                 Key: ZOOKEEPER-2747
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2747
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.2
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
> Currently when compiling ZooKeeper we se a compilation warning:
> {code}
>     [javac] /zookeeper/src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java:43:
warning: [try] auto-closeable resource ZooKeeperAdmin has a member method close() that could
throw InterruptedException
>     [javac] public class ZooKeeperAdmin extends ZooKeeper {
>     [javac]        ^
>     [javac] 2 warnings
> {code}
> This is due to the implementation of AutoCloseable in the ZooKeeper superclass. That
class has a warning suppression and explanation, we should copy it to the ZooKeeperAdmin class.

This message was sent by Atlassian JIRA

View raw message