zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times
Date Thu, 27 Apr 2017 23:23:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987879#comment-15987879
] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
-------------------------------------------

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/241#discussion_r113824039
  
    --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
    @@ -113,6 +116,26 @@ public void testAutoCreateDb() throws IOException {
             attemptAutoCreateDb(dataDir, snapDir, sessions, priorAutocreateDbValue, "false",
0L);
         }
     
    +    @Test
    +    public void testGetTxnLogSyncElapsedTime() throws IOException {
    --- End diff --
    
    Done. It looks like this one, so any suggestion to remove duplicate or improve it is welcome.


> Export a metric for txn log sync times
> --------------------------------------
>
>                 Key: ZOOKEEPER-2662
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Edward Ribeiro
>             Fix For: 3.6.0
>
>         Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync the txn
log in order to warn if that time exceeds a configurable threshold. This information should
also be exported as a metric available by JMX so an important aspect of quorum performance
can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server process
already, seems like a good place to put it if not an entirely new bean for the TxnLog. After
ZOOKEEPER-2310 might want to collect the same information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message