zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
Date Thu, 06 Apr 2017 02:54:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958213#comment-15958213
] 

ASF GitHub Bot commented on ZOOKEEPER-236:
------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r110070800
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -230,15 +232,15 @@ protected void sockConnect(Socket sock, InetSocketAddress addr,
int timeout)
         /**
          * Establish a connection with the Leader found by findLeader. Retries
          * until either initLimit time has elapsed or 5 tries have happened. 
    -     * @param addr - the address of the Leader to connect to.
    +     * @param leader - the QuorumServer elected leader
          * @throws IOException - if the socket connection fails on the 5th attempt
          * @throws ConnectException
          * @throws InterruptedException
          */
    -    protected void connectToLeader(InetSocketAddress addr) 
    -    throws IOException, ConnectException, InterruptedException {
    -        sock = new Socket();        
    -        sock.setSoTimeout(self.tickTime * self.initLimit);
    +    protected void connectToLeader(QuorumServer leader)
    +    throws IOException, InterruptedException, X509Exception {
    +        QuorumX509Util quorumX509Util = new QuorumX509Util();
    --- End diff --
    
    Agreed. Fixed


> SSL Support for Atomic Broadcast protocol
> -----------------------------------------
>
>                 Key: ZOOKEEPER-236
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: quorum, server
>            Reporter: Benjamin Reed
>            Assignee: Abraham Fine
>            Priority: Minor
>
> We should have the ability to use SSL to authenticate and encrypt the traffic between
ZooKeeper servers. For the most part this is a very easy change. We would probably only want
to support this for TCP based leader elections.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message