zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Sun, 30 Apr 2017 23:03:51 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r114086628
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -64,6 +66,8 @@
     
         protected InetSocketAddress clientPortAddress;
         protected InetSocketAddress secureClientPortAddress;
    +    protected boolean sslQuorum = false;
    +    protected boolean shouldUsePortUnification = false;
    --- End diff --
    
    This variables and special handling code can be removed, for a configuration property
that both available as system properties and available as part of zoo.cfg. In such case the
processing code will fall back as https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java#L296
and is consistent with the existing code style for configuration processing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message