zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leadi...
Date Fri, 28 Apr 2017 20:17:12 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/238#discussion_r114011352
  
    --- Diff: src/java/main/org/apache/jute/Utils.java ---
    @@ -190,19 +190,32 @@ static String fromCSVString(String s) throws IOException {
         }
         
         /**
    +     * convert byte array to a string in hex format
          * 
    -     * @param s 
    -     * @return 
    +     * @param barr
    +     * @return
          */
    -    static String toXMLBuffer(byte barr[]) {
    --- End diff --
    
    Are you sure about that? I know next to nothing about JAXB so I can definitely be wrong,
but I was able to drop `DatatypeConverter.printHexBinary` in place and have everything just
work. Digging through the implementation and DatatypeConverter instantiation happening behind
the scenes everything looked reasonable. Can you link me to something that shows what I am
missing?
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message